Re: [PATCH 3/3] bus: hisi_lpc: Expand build test coverage

[John Garry]

On 02/10/2019 16:43, Arnd Bergmann wrote:
> On Tue, Oct 1, 2019 at 6:07 PM John Garry <john.garry@xxxxxxxxxx> wrote:
> > Currently the driver will only ever be built for ARM64 because it selects
> > CONFIG_INDIRECT_PIO, which itself depends on ARM64.
> >
> > Expand build test coverage for the driver to other architectures by only
> > selecting CONFIG_INDIRECT_PIO for ARM64, when we really want it.
> >
> > Signed-off-by: John Garry <john.garry@xxxxxxxxxx>

Hi Arnd,

> Good idea, but doesn't this cause a link failure against
> logic_pio_register_range() when INDIRECT_PIO is disabled?

No, it shouldn't do. Function 
lib/logic_pio.c::logic_pio_register_range() is built always, outside any 
INDIRECT_PIO checking.

A some stage, for completeness we should probably change 
logic_pio_register_range() and friends to be under PCI_IOBASE. But then 
we would need stubs for !PCI_IOBASE, due to this above change and also 
references from the device tree code. I'd have to consider this a bit 
more. Let me know what you think.

Thanks,
John

>       Arnd