Re: [PATCH net] net: stmmac: Avoid deadlock on suspend/resume

[David Miller]

From: Thierry Reding <thierry.reding@xxxxxxxxx>
Date: Wed,  2 Oct 2019 16:49:46 +0200

> From: Thierry Reding <treding@xxxxxxxxxx>
> 
> The stmmac driver will try to acquire its private mutex during suspend
> via phylink_resolve() -> stmmac_mac_link_down() -> stmmac_eee_init().
> However, the phylink configuration is updated with the private mutex
> held already, which causes a deadlock during suspend.
> 
> Fix this by moving the phylink configuration updates out of the region
> of code protected by the private mutex.
> 
> Fixes: 19e13cb27b99 ("net: stmmac: Hold rtnl lock in suspend/resume callbacks")
> Suggested-by: Bitan Biswas <bbiswas@xxxxxxxxxx>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>

Applied.