Re: [RFC][PATCH 2/3] usb: roles: Add usb role switch notifier.

From: Greg Kroah-Hartman
Date: Thu Oct 03 2019 - 07:26:27 EST


On Wed, Oct 02, 2019 at 11:16:16PM +0000, John Stultz wrote:
> From: Yu Chen <chenyu56@xxxxxxxxxx>
>
> This patch adds notifier for drivers want to be informed of the usb role
> switch.

Ick, I hate notifiers, they always come back to cause problems.

What's just wrong with a "real" call to who ever needs to know this?
And who does need to know this anyway? Like Hans said, if we don't have
a user for it, we should not add it.

thanks,

greg k-h