Re: [PATCH v5 02/10] KVM: arm/arm64: Factor out hypercall handling from PSCI code
From: Andrew Jones
Date: Thu Oct 03 2019 - 08:23:13 EST
On Wed, Oct 02, 2019 at 03:50:29PM +0100, Steven Price wrote:
> From: Christoffer Dall <christoffer.dall@xxxxxxx>
>
> We currently intertwine the KVM PSCI implementation with the general
> dispatch of hypercall handling, which makes perfect sense because PSCI
> is the only category of hypercalls we support.
>
> However, as we are about to support additional hypercalls, factor out
> this functionality into a separate hypercall handler file.
>
> Signed-off-by: Christoffer Dall <christoffer.dall@xxxxxxx>
> [steven.price@xxxxxxx: rebased]
> Signed-off-by: Steven Price <steven.price@xxxxxxx>
> ---
> arch/arm/kvm/Makefile | 2 +-
> arch/arm/kvm/handle_exit.c | 2 +-
> arch/arm64/kvm/Makefile | 1 +
> arch/arm64/kvm/handle_exit.c | 4 +-
> include/Kbuild | 2 +
> include/kvm/arm_hypercalls.h | 43 ++++++++++++++++++
> include/kvm/arm_psci.h | 2 +-
> virt/kvm/arm/hypercalls.c | 59 +++++++++++++++++++++++++
> virt/kvm/arm/psci.c | 84 +-----------------------------------
> 9 files changed, 112 insertions(+), 87 deletions(-)
> create mode 100644 include/kvm/arm_hypercalls.h
> create mode 100644 virt/kvm/arm/hypercalls.c
>
Reviewed-by: Andrew Jones <drjones@xxxxxxxxxx>