Re: [PATCH v11 4/7] dt-bindings: sun6i-dsi: Add VCC-DSI supply property

From: Icenowy Zheng
Date: Thu Oct 03 2019 - 09:04:16 EST




ä 2019å10æ3æ GMT+08:00 äå7:47:33, Maxime Ripard <mripard@xxxxxxxxxx> åå:
>On Thu, Oct 03, 2019 at 12:15:24PM +0530, Jagan Teki wrote:
>> Allwinner MIPI DSI controllers are supplied with SoC DSI
>> power rails via VCC-DSI pin.
>>
>> Some board still work without supplying this but give more
>> faith on datasheet and hardware schematics and document this
>> supply property in required property list.
>>
>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>> Tested-by: Merlijn Wajer <merlijn@xxxxxxxxxx>
>> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
>> ---
>> .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 3
>+++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git
>a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml
>b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml
>> index 47950fced28d..9d4c25b104f6 100644
>> ---
>a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml
>> +++
>b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml
>> @@ -36,6 +36,9 @@ properties:
>> resets:
>> maxItems: 1
>>
>> + vcc-dsi-supply:
>> + description: VCC-DSI power supply of the DSI encoder
>> +
>
>The driver treats it as mandatory, so I've added it to the binding, as
>suggested by the commit log.

No. The regulator_get function will return dummy regulator, rather than
fail, if the regulator is not specified.

>
>Maxime

--
äç K-9 Mail åéèæçAndroidèåã