Re: [PATCH 1/2] dt-bindings: ptp: Add binding doc for IDT ClockMatrix based PTP clock
From: Vincent Cheng
Date: Thu Oct 03 2019 - 11:12:30 EST
On Tue, Oct 01, 2019 at 06:09:06PM EDT, Rob Herring wrote:
>On Wed, Sep 18, 2019 at 04:06:37PM -0400, vincent.cheng.xh@xxxxxxxxxxx wrote:
>> From: Vincent Cheng <vincent.cheng.xh@xxxxxxxxxxx>
Hi Rob,
Welcome back. Thank-you for providing feedback.
>>
>> Add device tree binding doc for the IDT ClockMatrix PTP clock driver.
>
>Bindings are for h/w, not drivers...
Yes, will remove 'driver'.
>> Documentation/devicetree/bindings/ptp/ptp-idtcm.txt | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/ptp/ptp-idtcm.txt
>
>Please make this a DT schema.
Sure, will give it a try.
>> + - compatible Should be "idt,8a3400x-ptp" for System Synchronizer
>> + Should be "idt,8a3401x-ptp" for Port Synchronizer
>> + Should be "idt,8a3404x-ptp" for Universal Frequency Translator (UFT)
>
>If PTP is the only function of the chip, you don't need to append
>'-ptp'.
Okay, will remove '-ptp'. Thanks.
>What's the 'x' for? We generally don't use wildcards in compatible
>strings.
We were hoping to use 'x' to represent a single driver to match the various
part numbers 8A34001, 8A34002, 8A34003, 8A34004, 8A34011, 8A34012, etc.
What should be used instead of 'x'?
Thanks,
Vincent