Re: [PATCH 1/4] dma: Add PTDMA Engine driver support

[Sanjay R Mehta]

On 9/24/2019 8:05 PM, Randy Dunlap wrote:
> [CAUTION: External Email]
>
> On 9/24/19 12:31 AM, Mehta, Sanju wrote:
>> From: Sanjay R Mehta <sanju.mehta@xxxxxxx>
>>
>> This is the driver for the AMD passthrough DMA Engine
>>
>> Signed-off-by: Sanjay R Mehta <sanju.mehta@xxxxxxx>
>> Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>
>> Reviewed-by: Rajesh Kumar <Rajesh1.Kumar@xxxxxxx>
>> ---
>> diff --git a/drivers/dma/ptdma/Kconfig b/drivers/dma/ptdma/Kconfig
>> new file mode 100644
>> index 0000000..a373431
>> --- /dev/null
>> +++ b/drivers/dma/ptdma/Kconfig
>> @@ -0,0 +1,7 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +config AMD_PTDMA
>> +     tristate  "AMD Passthru DMA Engine"
>> +     default m
> Can you justify "default m"?  Most likely it should not be here.
Agree . This will be resolved in next version of patch set.
>
>
>> +     depends on X86_64 && PCI
>> +     help
>> +       Provides the support for AMD Passthru DMA engine.
>
> --
> ~Randy