Re: [PATCH v2] KVM: x86: omit absent pmu MSRs from MSR list

From: Paolo Bonzini
Date: Thu Oct 03 2019 - 16:12:56 EST


On 03/10/19 20:23, Jim Mattson wrote:
> On Thu, Oct 3, 2019 at 10:38 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>>
>> On 03/10/19 19:20, Jim Mattson wrote:
>>> You've truncated the list I originally provided, so I think this need
>>> only go to MSR_ARCH_PERFMON_PERFCTR0 + 17. Otherwise, we could lose
>>> some valuable MSRs.
>>
>> This is v2, so it was meant to replace the patch that truncates the
>> list. But I can include the other one too, perhaps even ask the x86
>> maintainers about decreasing INTEL_PMC_MAX_GENERIC to 18.
>
> The list should definitely be truncated, since
> MSR_ARCH_PERFMON_EVENTSEL0 + 18 is IA32_PERF_STATUS.

Ok, thanks.

Paolo