Re: [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board

[Yannick FERTRE]

Hi Alex,

ok, i'll push only the dt patch link to the last version of driver 
touchscreen on display board MB1407.

BR

Yannick FertrÃ


On 10/3/19 12:34 PM, Alexandre Torgue wrote:
> Hi Yannick
>
> On 9/30/19 4:45 PM, Yannick Fertrà wrote:
>> Enable focaltech ft6236 touchscreen on STM32MP157C-DK2 board.
>> This device supports 2 different addresses (0x2a and 0x38)
>> depending on the display board version (MB1407).
>>
>> Signed-off-by: Yannick Fertrà <yannick.fertre@xxxxxx>
>> ---
>> Â arch/arm/boot/dts/stm32mp157c-dk2.dts | 23 +++++++++++++++++++++++
>> Â 1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts 
>> b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> index 20ea601..527bb75 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> @@ -61,6 +61,29 @@
>> ÂÂÂÂÂ };
>> Â };
>> Â +&i2c1 {
>> +ÂÂÂ touchscreen@2a {
>> +ÂÂÂÂÂÂÂ compatible = "focaltech,ft6236";
>> +ÂÂÂÂÂÂÂ reg = <0x2a>;
>> +ÂÂÂÂÂÂÂ interrupts = <2 2>;
>> +ÂÂÂÂÂÂÂ interrupt-parent = <&gpiof>;
>> +ÂÂÂÂÂÂÂ interrupt-controller;
>> +ÂÂÂÂÂÂÂ touchscreen-size-x = <480>;
>> +ÂÂÂÂÂÂÂ touchscreen-size-y = <800>;
>> +ÂÂÂÂÂÂÂ status = "okay";
>> +ÂÂÂ };
>> +ÂÂÂ touchscreen@38 {
>> +ÂÂÂÂÂÂÂ compatible = "focaltech,ft6236";
>> +ÂÂÂÂÂÂÂ reg = <0x38>;
>> +ÂÂÂÂÂÂÂ interrupts = <2 2>;
>> +ÂÂÂÂÂÂÂ interrupt-parent = <&gpiof>;
>> +ÂÂÂÂÂÂÂ interrupt-controller;
>> +ÂÂÂÂÂÂÂ touchscreen-size-x = <480>;
>> +ÂÂÂÂÂÂÂ touchscreen-size-y = <800>;
>> +ÂÂÂÂÂÂÂ status = "okay";
>> +ÂÂÂ };
>> +};
>
> I'm not confident by this duplication. We should only support the 
> latest revision of the MB1407. I understand the need but my fear is to 
> duplicate this node each time we have a new revision (and imagine if 
> we do that for all i2c devices).
>
> regards
> alex
>
>
>> Â &ltdc {
>> ÂÂÂÂÂ status = "okay";