Re: [PATCH 0/4] HiSilicon hip08 uncore PMU events additions

From: John Garry
Date: Fri Oct 04 2019 - 11:00:03 EST


On 04/10/2019 15:38, Arnaldo Carvalho de Melo wrote:
Em Fri, Oct 04, 2019 at 11:36:58AM -0300, Arnaldo Carvalho de Melo escreveu:
Em Fri, Oct 04, 2019 at 03:30:07PM +0100, John Garry escreveu:
On 04/09/2019 16:54, John Garry wrote:
This patchset adds some missing uncore PMU events for the hip08 arm64
platform.

The missing events were originally mentioned in
https://lkml.org/lkml/2019/6/14/645, when upstreaming the JSONs initially.

It also includes a fix for a DDRC eventname.

Hi guys,

Could I get these JSON updates picked up please? Maybe they were missed
earlier. Let me know if I should re-post.

Looking at them now.

It would be really good if somehow we managed to have someone from the
ARM community to check and provide a Reviewed-by for those, i.e. someone
else than the poster to look at it and check that its ok, would that be
possible?

Hi Arnaldo,

For this specific case, I'm not sure how much traction or value there would be since we're just adding some missing events for custom IP.

But I do agree that more review of JSONs from the community is required - as I brought up here regarding a recent addition: https://lore.kernel.org/lkml/749a0b8e-2bfd-28f6-b34d-dc72ef3d3a74@xxxxxxxxxx/

Can we enforce that at least linux-arm-kernel@xxxxxxxxxxxxxxxxxxx and/or get_maintainer.pl results is cc'ed on anything ARM specific as a start?

Cheers,
John


- Arnaldo

- Arnaldo

Thanks in advance,
John


John Garry (4):
perf jevents: Fix Hisi hip08 DDRC PMU eventname
perf jevents: Add some missing events for Hisi hip08 DDRC PMU
perf jevents: Add some missing events for Hisi hip08 L3C PMU
perf jevents: Add some missing events for Hisi hip08 HHA PMU

.../arm64/hisilicon/hip08/uncore-ddrc.json | 16 +++++-
.../arm64/hisilicon/hip08/uncore-hha.json | 23 +++++++-
.../arm64/hisilicon/hip08/uncore-l3c.json | 56 +++++++++++++++++++
3 files changed, 93 insertions(+), 2 deletions(-)



--

- Arnaldo