Re: [RESEND PATCH v2 0/3] Add driver for veml6030 ambient light sensor
From: Jonathan Cameron
Date: Sat Oct 05 2019 - 10:08:46 EST
On Tue, 24 Sep 2019 16:21:55 +0530
Rishi Gupta <gupt21@xxxxxxxxx> wrote:
When doing a RESEND as opposed to a new version, please say
why.
> The veml6030 is an ambient light sensor from vishay and
> is a different hardware from an existing hardware for which
> driver currently exist, therefore this driver submission.
>
> * All features; ALS, white channel & power management is
> supported.
>
> * All configurable parameters are supported through standard
> iio sysfs entries. User space can get valid values of any
> parameter (xx_available) and then can write to appropriate
> sysfs entry.
>
> * User space can get ALS & White channel readings through RAW
> IIO interface.
>
> * IIO events are used to notify application whenever threshold
> is crossed. This uses IRQ pin of veml6030.
>
> * Some registers in veml6030 are read only. For these registers
> read callback returns error to user space.
>
> There are 3 patches for this submission:
> [PATCH 1/3] iio: light: add driver for veml6030 ambient light sensor
> [PATCH 2/3] dt-bindings: iio: light: add veml6030 ALS bindings
> [PATCH 3/3] iio: documentation: light: Add veml6030 sysfs documentation
>
> Rishi Gupta (3):
> iio: light: add driver for veml6030 ambient light sensor
> dt-bindings: iio: light: add veml6030 ALS bindings
> iio: documentation: light: Add veml6030 sysfs documentation
>
> .../ABI/testing/sysfs-bus-iio-light-veml6030 | 49 ++
> .../devicetree/bindings/iio/light/veml6030.yaml | 62 ++
> drivers/iio/light/Kconfig | 11 +
> drivers/iio/light/Makefile | 1 +
> drivers/iio/light/veml6030.c | 633 +++++++++++++++++++++
> 5 files changed, 756 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-light-veml6030
> create mode 100644 Documentation/devicetree/bindings/iio/light/veml6030.yaml
> create mode 100644 drivers/iio/light/veml6030.c
>