Re: [PATCH v4 3/4] xen: Mark "xen_nopvspin" parameter obsolete

[Zhenzhong Duan]

On 2019/10/4 22:57, Boris Ostrovsky wrote:
> On 10/3/19 10:02 AM, Zhenzhong Duan wrote:
> > Map "xen_nopvspin" to "nopvspin", fix stale description of "xen_nopvspin"
> > as we use qspinlock now.
> >
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>
> > Cc: Jonathan Corbet <corbet@xxxxxxx>
> > Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > Cc: Juergen Gross <jgross@xxxxxxxx>
> > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>
> with a small nit
>
> >   void __init xen_init_spinlocks(void)
> >   {
> > +	if (nopvspin)
> > +		xen_pvspin = false;
> >   
> >   	/*  Don't need to use pvqspinlock code if there is only 1 vCPU. */
> >   	if (num_possible_cpus() == 1)
> I'd fold the change into this 'if' statement, I think it will still be
> clear what the comment refers to.

Good suggestion, will do that. Thanks

Zhenzhong