Re: [PATCH v4 1/2] dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS

From: Shenhar, Talel
Date: Sun Oct 06 2019 - 05:19:18 EST


thanks for the review.

On 10/4/2019 6:05 PM, Rob Herring wrote:
On Thu, Oct 3, 2019 at 6:33 AM Talel Shenhar <talel@xxxxxxxxxx> wrote:

Fails 'make dt_binding_check' (drop the '-'):
ack, shall be part of v5

+
+examples:
+ - |
+ al_pos_edac@f0070084 {
edac@...
ack, shall be part of v5

+ compatible = "amazon,al-pos-edac";
+ reg = <0x0 0xf0070084 0x0 0x00000008>;
+ interrupt-parent = <&amazon_system_fabric>;
+ interrupts = <24 IRQ_TYPE_LEVEL_HIGH>;
Not documented.

looks good?

ÂÂ interrupts:

ÂÂÂ description: Interrupt for the error event.
ÂÂÂ maxItems: 1