Re: [PATCH] scripts: add_namespace: Fix coccicheck failed

[Matthias Maennich]

Hi YueHaibing!

On Sun, Oct 06, 2019 at 12:44:56PM +0800, YueHaibing wrote:
> Now all scripts in scripts/coccinelle to be automatically called
> by coccicheck. However new adding add_namespace.cocci does not
> support report mode, which make coccicheck failed.
> This add "virtual report" to  make the coccicheck go ahead smoothly.
>
> Fixes: eb8305aecb95 ("scripts: Coccinelle script for namespace dependencies.")
> Acked-by: Julia Lawall <julia.lawall@xxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Thanks for fixing this!

Acked-by: Matthias Maennich <maennich@xxxxxxxxxx>

Cheers,
Matthias

> ---
> scripts/coccinelle/misc/add_namespace.cocci | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/coccinelle/misc/add_namespace.cocci b/scripts/coccinelle/misc/add_namespace.cocci
> index c832bb6445a8..99e93a6c2e24 100644
> --- a/scripts/coccinelle/misc/add_namespace.cocci
> +++ b/scripts/coccinelle/misc/add_namespace.cocci
> @@ -6,6 +6,8 @@
> /// add a missing namespace tag to a module source file.
> ///
>
> +virtual report
> +
> @has_ns_import@
> declarer name MODULE_IMPORT_NS;
> identifier virtual.ns;
> --
> 2.20.1