Re: [PATCH] staging: comedi: Fix camelcase check warning

From: Greg KH
Date: Sun Oct 06 2019 - 15:09:06 EST


On Sun, Oct 06, 2019 at 07:44:53PM +0100, Jules Irenge wrote:
> Capitalize unit_ma to fix camelcase check warning.
>
> Signed-off-by: Jules Irenge <jbi.octave@xxxxxxxxx>
> ---
> drivers/staging/comedi/comedi.h | 4 ++--
> drivers/staging/comedi/comedidev.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 09a940066c0e..df770043b37d 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -674,7 +674,7 @@ struct comedi_rangeinfo {
> * linear (for the purpose of describing the range), with sample value %0
> * mapping to @min, and the 'maxdata' sample value mapping to @max.
> *
> - * The currently defined units are %UNIT_volt (%0), %UNIT_mA (%1), and
> + * The currently defined units are %UNIT_volt (%0), %UNIT_MA (%1), and
> * %UNIT_none (%2). The @min and @max values are the physical range multiplied
> * by 1e6, so a @max value of %1000000 (with %UNIT_volt) represents a maximal
> * value of 1 volt.
> @@ -909,7 +909,7 @@ struct comedi_bufinfo {
> #define RF_EXTERNAL 0x100
>
> #define UNIT_volt 0
> -#define UNIT_mA 1
> +#define UNIT_MA 1

Sorry, but "mA" is a unit of measurement of power, and needs to stay
as-is.

thanks,

greg k-h