Re: [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers

[Alexandre Belloni]

On 02/10/2019 18:07:42+0200, Krzysztof Kozlowski wrote:
> Make the examples in S3C RTC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>

> ---
>  Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 95570d7e19eb..4d91cdc9b998 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -75,11 +75,14 @@ allOf:
>  
>  examples:
>    - |
> +    #include <dt-bindings/clock/exynos5420.h>
> +    #include <dt-bindings/clock/samsung,s2mps11.h>
> +
>      rtc@10070000 {
>          compatible = "samsung,s3c6410-rtc";
>          reg = <0x10070000 0x100>;
>          interrupts = <0 44 4>, <0 45 4>;
> -        clocks = <&clock 0>, // CLK_RTC
> -                 <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> +        clocks = <&clock CLK_RTC>,
> +                 <&s2mps11_osc S2MPS11_CLK_AP>;
>          clock-names = "rtc", "rtc_src";
>      };
> -- 
> 2.17.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com