Re: [PATCH 0/4] HiSilicon hip08 uncore PMU events additions

From: John Garry
Date: Mon Oct 07 2019 - 09:41:03 EST



As an alternative, how about just add a maintainers entry for reviewers per
arch? As a start, I don't mind being added there for arm64:

--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12767,6 +12767,10 @@ F: arch/*/events/*
F: arch/*/events/*/*
F: tools/perf/

+PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
+R: John Garry <john.garry@xxxxxxxxxx>
+F: tools/perf/pmu-events/arch/arm64
+

Patches per-arch should have some nod/tag from a member of the respective
list. Or at very least be cc'ed :)

Another Ok, please send a formal patch, and it would be really nice if
the other ARM folks would... Ack that ;-) :-) And provide extra entries
for the other pmu-events directories or even for specific files, which
is a possibility, right?

ok, can do. Will has kindly agreed to have his name added to the MAINTAINERS entry (thanks). Other Cc's from ARM community may also be interested to be included - shout if so.

So I'll just include tools/perf/pmu-events/arch/arm64 for now.

The code in tools/perf/pmu-events/. should be generic for all architectures, while I'd say tools/perf/arch/arm64 is not strictly related.

Thanks,
John


On my side I'll script a bit more and make sure that a post commit hook
warns me if the right tag is not present.

- Arnaldo

.