Re: [PATCH] nvme-pci: Shutdown when removing dead controller
From: Tyler Ramer
Date: Mon Oct 07 2019 - 11:12:36 EST
> Setting the shutdown to true is
> usually just to get the queues flushed, but the nvme_kill_queues() that
> we call accomplishes the same thing.
The intention of this patch was to clean up another location where
nvme_dev_disable()
is called with shutdown == false, but the device is being removed due
to a failure
condition, so it should be shutdown.
Perhaps though, given nvme_kill_queues() provides a subset of the
functionality of
nvme_dev_disable() with shutdown == true, we can just use
nvme_dev_disable() and
remove nvme_kill_queues()?
This will make nvme_remove_dead_ctrl() more in line with nvme_remove(),
nvme_shutdown(), etc.
- Tyler