Re: [PATCH 4.4 00/36] 4.4.196-stable review

[Guenter Roeck]

On 10/7/19 6:49 PM, Sasha Levin wrote:
> On Mon, Oct 07, 2019 at 04:16:51PM -0700, Guenter Roeck wrote:
> > On 10/7/19 4:07 PM, Sasha Levin wrote:
> > > On Mon, Oct 07, 2019 at 04:49:51PM +0200, Greg Kroah-Hartman wrote:
> > > > On Mon, Oct 07, 2019 at 05:53:55AM -0700, Guenter Roeck wrote:
> > > > > On 10/6/19 10:18 AM, Greg Kroah-Hartman wrote:
> > > > > > This is the start of the stable review cycle for the 4.4.196 release.
> > > > > > There are 36 patches in this series, all will be posted as a response
> > > > > > to this one. If anyone has any issues with these being applied, please
> > > > > > let me know.
> > > > > >
> > > > > > Responses should be made by Tue 08 Oct 2019 05:07:10 PM UTC.
> > > > > > Anything received after that time might be too late.
> > > > >
> > > > > powerpc:defconfig fails to build.
> > > > >
> > > > > arch/powerpc/kernel/eeh_driver.c: In function âeeh_handle_normal_eventâ:
> > > > > arch/powerpc/kernel/eeh_driver.c:678:2: error: implicit declaration of function âeeh_for_each_peâ; did you mean âbus_for_each_devâ?
> > > > >
> > > > > It has a point:
> > > > >
> > > > > ... HEAD is now at 13cac61d31df Linux 4.4.196-rc1
> > > > > $ git grep eeh_for_each_pe
> > > > > arch/powerpc/kernel/eeh_driver.c:ÂÂÂÂÂÂ eeh_for_each_pe(pe, tmp_pe)
> > > > > arch/powerpc/kernel/eeh_driver.c:ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ eeh_for_each_pe(pe, tmp_pe)
> > > > >
> > > > > Caused by commit 3fb431be8de3a ("powerpc/eeh: Clear stale EEH_DEV_NO_HANDLER flag").
> > > > > Full report will follow later.
> > > >
> > > > Thanks for letting me know, I've dropped this from the queue now and
> > > > pushed out a -rc2 with that removed.
> > > >
> > > > Sasha, I thought your builder would have caught stuff like this?
> > >
> > > Interesting, the 4.4 build fails for me with vanilla 4.4 LTS kernel
> > > (which is why this was missed):
> > >
> > > ÂASÂÂÂÂÂ arch/powerpc/kernel/systbl.o
> > > arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> > > arch/powerpc/kernel/exceptions-64s.S:1599: Warning: invalid register expression
> > > arch/powerpc/kernel/exceptions-64s.S:1640: Warning: invalid register expression
> > > arch/powerpc/kernel/exceptions-64s.S:839: Error: attempt to move .org backwards
> > > arch/powerpc/kernel/exceptions-64s.S:840: Error: attempt to move .org backwards
> > > arch/powerpc/kernel/exceptions-64s.S:864: Error: attempt to move .org backwards
> > > arch/powerpc/kernel/exceptions-64s.S:865: Error: attempt to move .org backwards
> > > scripts/Makefile.build:375: recipe for target 'arch/powerpc/kernel/head_64.o' failed
> >
> > Is this allmodconfig ? That is correct - it won't build in 4.4.y, and it would not be
> > easy to fix.
>
> Oh, interesting, so no allmodconfig? I've disabled everything but
> allmodconfig on a few architectures in an attempt to save to build time.

If I recall correctly, it stopped working quite some time ago for v4.4.y, and the powerpc
maintainers didn't want to spend the time fixing it. It works with v4.9.y and later.

Guenter