Re: [PATCH] proc:fix confusing macro arg name

[Li, Aubrey]

On 2019/10/8 14:44, linmiaohe wrote:
> Add suitable additional cc's as Andrew Morton suggested.
> Get cc list from get_maintainer script:
> [root@localhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch 
> Alexey Dobriyan <adobriyan@xxxxxxxxx> (reviewer:PROC FILESYSTEM)
> linux-kernel@xxxxxxxxxxxxxxx (open list:PROC FILESYSTEM)
> linux-fsdevel@xxxxxxxxxxxxxxx (open list:PROC FILESYSTEM)
> 
> ------------------------------------------------------
> From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> Subject: fix confusing macro arg name
> 
> state_size and ops are in the wrong position, fix it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---

Good catch!

This is interesting, I saw this interface has 50+ callers,
How did they work before? ;)

Thanks,
-Aubrey

> 
>  include/linux/proc_fs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index a705aa2d03f9..0640be56dcbd 100644
> --- a/include/linux/proc_fs.h
> +++ b/include/linux/proc_fs.h
> @@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *);  struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
>  		struct proc_dir_entry *parent, const struct seq_operations *ops,
>  		unsigned int state_size, void *data);
> -#define proc_create_net(name, mode, parent, state_size, ops) \
> -	proc_create_net_data(name, mode, parent, state_size, ops, NULL)
> +#define proc_create_net(name, mode, parent, ops, state_size) \
> +	proc_create_net_data(name, mode, parent, ops, state_size, NULL)
>  struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
>  		struct proc_dir_entry *parent,
>  		int (*show)(struct seq_file *, void *), void *data);
> --
> 2.21.GIT
> 
>