Re: Lay common foundation to make PVR/SGX work without hacks on OMAP34xx, OMAP36xx, AM335x and potentially OMAP4, OMAP5

[Tero Kristo]

On 07/10/2019 22:24, H. Nikolaus Schaller wrote:
> Hi Tero,
>
> > Am 07.10.2019 um 21:18 schrieb Tero Kristo <t-kristo@xxxxxx>:
> >
> > On 07/10/2019 18:52, Tony Lindgren wrote:
> > > Hi,
> > > * H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> [191005 16:59]:
> > > Please try with Tero's current github branch at github.com/t-kristo/linux-pm.git
> > > 5.4-rc1-ipc from few days ago, the earlier versions had still issues.
> >
> > Yeah, this one should be fixed now.
>
> Ok! Will try asap.
>
> > > > * OMAP5 (Pyra): fails to enable the clocks (did work with the previous version)
> > > > [  304.140363] clock-controller:clk:0000:0: failed to enable
> > > > [  304.147388] PVR_K:(Error): EnableSGXClocks: pm_runtime_get_sync failed (16)
> > > Hmm no idea what might be up with this one. Did some clkctrl clock
> > > fixes maybe cause a regression here? Tero do you have any ideas?
> >
> > So, this one I am not too sure, I haven't looked at omap5 graphics clocking. I don't think it has anything to do with reset handling though.
> >
> > Is there some simple way to try this out on board; without PVR module that is?
>
> Yes, I have also seen it when just running the commands in the original commit message [1]:
>
> # echo on > $(find /sys -name control | grep \/5600)
> # rwmem 0x5600fe00	# OCP Revision
> 0x5600fe00 = 0x40000000
> # echo auto > $(find /sys -name control | grep \/5600)
> # rwmem 0x5600fe10
> # rwmem 0x56000024
>
> But I have not yet tested with 5.4-rc2, just 5.4-rc1.

Ok, there is a one liner DTS data fix for this issue, attached.

-Tero

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki