Re: [PATCH] drm/komeda: Adds output-color format/depth support

[Lowry Li (Arm Technology China)]

On Mon, Sep 30, 2019 at 10:36:27AM +0000, Brian Starkey wrote:
> On Fri, Sep 27, 2019 at 02:22:24AM +0000, james qian wang (Arm Technology China) wrote:
> > On Wed, Sep 25, 2019 at 09:48:11AM +0000, Brian Starkey wrote:
> > > Hi James,
> > > 
> > > On Tue, Sep 24, 2019 at 02:13:27AM +0000, james qian wang (Arm Technology China) wrote:
> > > > 
> > > > Hi Brian:
> > > > 
> > > > Since one monitor can support mutiple color-formats, this DT property
> > > > supply a way for user to select a specific one from this supported
> > > > color-formats.
> > > 
> > > Modifying DT is a _really_ user-unfriendly way of specifying
> > > preferences. If we want a user to be able to pick a preferred format,
> > > then it should probably be via the atomic API as Ville mentioned.
> > >
> > 
> > Hi Brian:
> > 
> > Agree, a drm UPAI might be the best & right way for this.
> > 
> > I can raise a new thread/topic to discuss the "HOW TO", maybe after the
> > Chinese national day.
> > 
> > LAST:
> > what do you think about this patch:
> > - Just drop it, waiting for the new uapi
> > - or keep it, and replace it once new uapi is ready.
> 
> The bit-depth stuff is clear and non-controversial, so you could split
> that out and merge it.
> 
> For the YUV stuff, I think it would be fine to merge the
> implementation that we discussed here - force YUV for modes which must
> be YUV, and leave the user-preference stuff for a later UAPI.
> 
> Thanks,
> -Brian
> 
Hi Brian,
We've split color depth out. Thanks for your comments.
https://patchwork.freedesktop.org/series/67730/

Regards,
Lowry
> > 
> > Thanks
> > James
> > 
> > > Cheers,
> > > -Brian