Re: [PATCH v8 3/6] PCI: Change extend_bridge_window() to set resource size directly

From: mika.westerberg@xxxxxxxxxxxxxxx
Date: Tue Oct 08 2019 - 08:05:06 EST


On Fri, Jul 26, 2019 at 12:54:01PM +0000, Nicholas Johnson wrote:
> Change extend_bridge_window() to set resource size directly instead of
> using additional resource lists.
>
> Because additional resource lists are optional resources, any algorithm
> that requires guaranteed allocation that uses them cannot be guaranteed
> to work.
>
> Remove the resource from add_list. If it is set to zero size and left,
> it can cause significant problems when it comes to assigning resources.

It would be good if you would open bit more what kind of significant
problems this may result.

> Signed-off-by: Nicholas Johnson <nicholas.johnson-opensource@xxxxxxxxxxxxxx>

Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>