Re: [PATCH 1/2] Drivers: hv: vmbus: Introduce table of VMBus protocol versions

From: Andrea Parri
Date: Tue Oct 08 2019 - 08:45:02 EST


> IIUC, you're suggesting that I do:
>
> for (i = 0; i < ARRAY_SIZE(vmbus_versions); i++) {
> version = vmbus_versions[i];
>
> ret = vmbus_negotiate_version(msginfo, version);
> if (ret == -ETIMEDOUT)
> goto cleanup;
>
> if (vmbus_connection.conn_state == CONNECTED)
> break;
> }
>
> if (vmbus_connection.conn_state != CONNECTED)
> break;

This "break" should have been "goto cleanup". Sorry.

Andrea