Re: [PATCH v2 0/2] extcon: axp288: Move to swnodes

[Hans de Goede]

Hi,

On 08-10-2019 14:25, Heikki Krogerus wrote:
> Hi Hans,
>
> Fixed the compiler warning in this version. No other changes.
>
> The original cover letter:
>
> That AXP288 extcon driver is the last that uses build-in connection
> description. I'm replacing it with a code that finds the role mux
> software node instead.
>
> I'm proposing also here a little helper
> usb_role_switch_find_by_fwnode() that uses
> class_find_device_by_fwnode() to find the role switches.

Both patches look good to me and I can confirm that things still
work as they should on a CHT device with an AXP288 PMIC, so for both:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans



p.s.

I guess this means we can remove the build-in connection (
device_connection_add / remove) stuff now?