Re: [PATCH] staging: vchiq: don't leak kernel address

From: Greg Kroah-Hartman
Date: Tue Oct 08 2019 - 11:15:53 EST


On Tue, Oct 08, 2019 at 05:25:17PM +0300, Dan Carpenter wrote:
> On Tue, Oct 08, 2019 at 04:21:54PM +0200, Matteo Croce wrote:
> > On Tue, Oct 8, 2019 at 3:16 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > >
> > > The subject doesn't match the patch. It should just be "remove useless
> > > printk".
> > >
> > > regards,
> > > dan carpenter
> > >
> >
> > Well, it avoids leaking an address by removing an useless printk.
> > It seems that GKH already picked the patch in his staging tree, but
> > I'm fine with both subjects, really,
>
> The address wasn't leaked because it was already %pK. The subject
> says there is an info leak security problem, when the opposite is true.

I've edited the subject line now.

thanks,

greg k-h