Re: [PATCH] arm64: lse: fix LSE atomics with LLVM's integrated assembler
From: Robin Murphy
Date: Tue Oct 08 2019 - 12:18:58 EST
On 08/10/2019 16:22, Sami Tolvanen wrote:
On Mon, Oct 7, 2019 at 2:46 PM 'Nick Desaulniers' via Clang Built
Linux <clang-built-linux@xxxxxxxxxxxxxxxx> wrote:
I'm worried that one of these might lower to LSE atomics without
ALTERNATIVE guards by blanketing all C code with `-march=armv8-a+lse`.
True, that's a valid concern. I think adding the directive to each
assembly block is the way forward then, assuming the maintainers are
fine with that.
It's definitely a valid concern in principle, but in practice note that
lse.h ends up included in ~99% of C files, so the extension is enabled
more or less everywhere already.
(based on a quick hack involving '#pragma message' and grepping the
build logs)
Robin.