Re: [PATCH] checkpatch: use patch subject when reading from stdin
From: Joe Perches
Date: Tue Oct 08 2019 - 14:50:08 EST
On Tue, 2019-10-08 at 20:39 +0200, Geert Uytterhoeven wrote:
[]
> > I still think the patch I suggested is better as it
> > functions for other use cases too.
>
> I agree it would be better if checkpatch would handle the splitting in
> patches itself, as that would be easier for the user.
>
> However:
> 1) That requires getting the state reset right,
Not really difficult and maybe not necessary.
The process subroutine contains very limited state.
The biggest issue is resetting the "$in_header_lines"
states and such when a new multi-patch bundle
start is detected. I'm not sure it actually impacts
the checkpatch output much. Maybe it'd not emit a
>75 character warning when scanning commit log messages.
> 2) Using formail is the classical old UNIX way (combine small tools
> to get the job done ;-)
Which doesn't impact your use case as formail is
already running checkpatch multiple times.
cheers, Joe