Re: [PATCH v11 07/22] riscv: mm: Add p?d_leaf() definitions

[Paul Walmsley]

On Mon, 7 Oct 2019, Steven Price wrote:

> walk_page_range() is going to be allowed to walk page tables other than
> those of user space. For this it needs to know when it has reached a
> 'leaf' entry in the page tables. This information is provided by the
> p?d_leaf() functions/macros.
> 
> For riscv a page is a leaf page when it has a read, write or execute bit
> set on it.
> 
> CC: Palmer Dabbelt <palmer@xxxxxxxxxx>
> CC: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
> CC: linux-riscv@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Steven Price <steven.price@xxxxxxx>

Acked-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx> # for arch/riscv  

Alex has a good point, but probably the right thing to do is to replace 
the contents of the arch/riscv/mm/hugetlbpage.c p{u,m}d_huge() functions 
with calls to Steven's new static inline functions.


- Paul