Re: [PATCH v2 0/2] Avoid regmap debugfs collisions in qcom llcc driver

[Stephen Boyd]

Quoting Bjorn Andersson (2019-10-08 16:55:04)
> On Tue 08 Oct 16:45 PDT 2019, Stephen Boyd wrote:
> >     @@ drivers/soc/qcom/llcc-slice.c
> >       
> >       static struct llcc_drv_data *drv_data = (void *) -EPROBE_DEFER;
> >       
> >     --static const struct regmap_config llcc_regmap_config = {
> >     +-static struct regmap_config llcc_regmap_config = {
> >      -        .reg_bits = 32,
> >      -        .reg_stride = 4,
> >      -        .val_bits = 32,
> >     @@ drivers/soc/qcom/llcc-slice.c: static struct regmap *qcom_llcc_init_mmio(struct
> >       {
> >               struct resource *res;
> >               void __iomem *base;
> >     -+        static struct regmap_config llcc_regmap_config = {
> >     ++        struct regmap_config llcc_regmap_config = {
> 
> Now that this isn't static I like the end result better. Not sure about
> the need for splitting it in two patches, but if Evan is happy I'll take
> it.
> 

Well I split it into bug fix and micro-optimization so backport choices
can be made. But yeah, I hope Evan is happy enough to provide a
reviewed-by tag!