Re: [PATCH v4 0/5] Powerpc/Watchpoint: Few important fixes

[Christophe Leroy]

Le 07/10/2019 Ã 08:35, Ravi Bangoria a ÃcritÂ:
> On 9/25/19 9:36 AM, Ravi Bangoria wrote:
> > v3: https://lists.ozlabs.org/pipermail/linuxppc-dev/2019-July/193339.html
> >
> > v3->v4:
> > Â - Instead of considering exception as extraneous when dar is outside of
> > ÂÂÂ user specified range, analyse the instruction and check for overlap
> > ÂÂÂ between user specified range and actual load/store range.
> > Â - Add selftest for the same in perf-hwbreak.c
> > Â - Make ptrace-hwbreak.c selftest more strict by checking address in
> > ÂÂÂ check_success.
> > Â - Support for 8xx in ptrace-hwbreak.c selftest (Build tested only)
> > Â - Rebase to powerpc/next
> >
> > @Christope, Can you please check Patch 5. I've just build-tested it
> > with ep88xc_defconfig.
>
> @mpe, @mikey, Any feedback?
>
> @Christophe, Is patch5 works for you on 8xx?

Getting the following :

root@vgoip:~# ./ptrace-hwbreak
test: ptrace-hwbreak
tags: git_version:v5.4-rc2-710-gf0082e173fe4-dirty
PTRACE_SET_DEBUGREG, WO, len: 1: Ok
PTRACE_SET_DEBUGREG, WO, len: 2: Ok
PTRACE_SET_DEBUGREG, WO, len: 4: Ok
PTRACE_SET_DEBUGREG, WO, len: 8: Ok
PTRACE_SET_DEBUGREG, RO, len: 1: Ok
PTRACE_SET_DEBUGREG, RO, len: 2: Ok
PTRACE_SET_DEBUGREG, RO, len: 4: Ok
PTRACE_SET_DEBUGREG, RO, len: 8: Ok
PTRACE_SET_DEBUGREG, RW, len: 1: Ok
PTRACE_SET_DEBUGREG, RW, len: 2: Ok
PTRACE_SET_DEBUGREG, RW, len: 4: Ok
PTRACE_SET_DEBUGREG, RW, len: 8: Ok
PPC_PTRACE_SETHWDEBUG, MODE_EXACT, WO, len: 1: Ok
PPC_PTRACE_SETHWDEBUG, MODE_EXACT, RO, len: 1: Ok
PPC_PTRACE_SETHWDEBUG, MODE_EXACT, RW, len: 1: Ok
PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW ALIGNED, WO, len: 6: Ok
PPC_PTRACE_SETHWDEBUG, MODE_RANGE, DW ALIGNED, RO, len: 6: Fail
failure: ptrace-hwbreak

Christophe