Re: [PATCH 3/3] Input: mms114 - add support for mms345l

From: Dmitry Torokhov
Date: Wed Oct 09 2019 - 16:40:25 EST


On Wed, Oct 09, 2019 at 10:26:12AM +0300, Andi Shyti wrote:
> Hi Dmitry,
>
> > > There was a related patch [2] that removes I2C_M_NOSTART for all models,
> > > but it seems abandoned and I do not have any other model for testing.
> > > Therefore, this patch implements the least instrusive solution
> > > and only removes I2C_M_NOSTART for MMS345L.
> >
> > Hmm, at this point I am inclined to pick up Andi's patch since it seems
> > to work for you and him and it looks like Android drivers are not using
> > I2C_M_NOSTART. I wonder if this was some quirk/big on the platform where
> > it was originally developed.
>
> I completely forgot about that patch :)
>
> I should refresh some old work on that device which was left
> undone.
>
> > Any objections?
>
> It's OK for me. If you can just update my e-mail, please, when
> applying the patch to "andi@xxxxxxxxxxx". Thanks!

Andi, any chance you could resend it with the new email? One thing that
I try to avoid modifying whenever I can is S-O-B strings...

Thanks.

--
Dmitry