[PATCH] staging: sm750fb: Potential uninitialized field in "pll"

From: Yizhuo
Date: Thu Oct 10 2019 - 00:37:27 EST


Inside function set_chip_clock(), struct pll is supposed to be
initialized in sm750_calc_pll_value(), if condition
"diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled,
then some field of pll will not be initialized but used in
function sm750_format_pll_reg(), which is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@xxxxxxx>
---
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 5a317cc98a4b..31b3cf9c2d8b 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -55,7 +55,7 @@ static unsigned int get_mxclk_freq(void)
*/
static void set_chip_clock(unsigned int frequency)
{
- struct pll_value pll;
+ struct pll_value pll = {};
unsigned int actual_mx_clk;

/* Cheok_0509: For SM750LE, the chip clock is fixed. Nothing to set. */
--
2.17.1