Re: [RFC PATCH 06/13] vsock: add 'struct vsock_sock *' param to vsock_core_get_transport()

From: Stefano Garzarella
Date: Thu Oct 10 2019 - 04:50:29 EST


On Wed, Oct 09, 2019 at 12:54:33PM +0100, Stefan Hajnoczi wrote:
> On Fri, Sep 27, 2019 at 01:26:56PM +0200, Stefano Garzarella wrote:
> > -const struct vsock_transport *vsock_core_get_transport(void)
> > +const struct vsock_transport *vsock_core_get_transport(struct vsock_sock *vsk)
> > {
> > /* vsock_register_mutex not taken since only the transport uses this
> > * function and only while registered.
> > */
> > - return transport_single;
>
> This comment is about protecting transport_single. It no longer applies
> when using vsk->transport. Please drop it.

Right, dropped.

>
> Otherwise:
>
> Reviewed-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>

Thanks,
Stefano