Re: [RESEND PATCH v4 2/2] uacce: add uacce driver
From: Greg Kroah-Hartman
Date: Thu Oct 10 2019 - 08:33:05 EST
On Wed, Oct 09, 2019 at 11:21:42PM +0800, Zhangfei Gao wrote:
> From: Kenneth Lee <liguozhu@xxxxxxxxxxxxx>
>
> Uacce (Unified/User-space-access-intended Accelerator Framework) targets to
> provide Shared Virtual Addressing (SVA) between accelerators and processes.
> So accelerator can access any data structure of the main cpu.
> This differs from the data sharing between cpu and io device, which share
> data content rather than address.
> Since unified address, hardware and user space of process can share the
> same virtual address in the communication.
>
> Uacce create a chrdev for every registration, the queue is allocated to
> the process when the chrdev is opened. Then the process can access the
> hardware resource by interact with the queue file. By mmap the queue
> file space to user space, the process can directly put requests to the
> hardware without syscall to the kernel space.
>
> Signed-off-by: Kenneth Lee <liguozhu@xxxxxxxxxxxxx>
> Signed-off-by: Zaibo Xu <xuzaibo@xxxxxxxxxx>
> Signed-off-by: Zhou Wang <wangzhou1@xxxxxxxxxxxxx>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
No one is using these new apis you are creating, so we can not judge if
they are correct or not. Please submit this as a patch series with a
driver that is actually going to use this api.
thanks,
greg k-h