Re: [PATCH] MIPS: add support for SGI Octane (IP30)

[Thomas Bogendoerfer]

On Wed, 9 Oct 2019 11:43:11 -0700
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> > +++ b/arch/mips/sgi-ip30/ip30-pci.c
> > @@ -0,0 +1,19 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * ip30-pci.c: misc PCI related helper code for IP30 architecture
> > + */
> > +
> > +#include <asm/pci/bridge.h>
> > +
> > +dma_addr_t __phys_to_dma(struct device *dev, phys_addr_t paddr)
> > +{
> > +	struct pci_dev *pdev = to_pci_dev(dev);
> > +	struct bridge_controller *bc = BRIDGE_CONTROLLER(pdev->bus);
> > +
> > +	return bc->baddr + paddr;
> > +}
> > +
> > +phys_addr_t __dma_to_phys(struct device *dev, dma_addr_t dma_addr)
> > +{
> > +	return dma_addr & ~(0xffUL << 56);
> > +}
> 
> This file is duplicated from ip27.  I think we should aim to share
> it given the common hardware even if it is mostly trivial.

ok, as far as I can anticipate IP35 verion of this functions will be
the same as well. So I'll move both into pci-xtalk-bridge.c in the
next version of the patch.

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 247165 (AG München)
Geschäftsführer: Felix Imendörffer