Re: Serial 8250 DMA Broken on OMAP3630

[Adam Ford]

On Wed, Oct 9, 2019 at 3:16 PM Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>
> * Adam Ford <aford173@xxxxxxxxx> [191009 19:28]:
> > On Wed, Oct 9, 2019 at 12:34 PM Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> > > From what I recall I tested that DMA on omap3 worked fine with runtime
> > > PM for console. Certainly there are issues still remaining though.
> > >
> > > If you want to disable dma for a specific port, just delete the
> > > add /delete-property/dma-names for the port in question in your
> > > board specific dts file.
> > >
> > > See 8250_omap.c for of_property_count_strings(np, "dma-names").
> >
> > Thank you.  That seems to have worked.  I'll check the AM3517 when I
> > have some time to see if it needs the same patch.  For now, I pushed
> > the patch to the omap mailing list for the Logic PD Torpedo board.
> >
> > Should we consider removing the OMAP_SERIAL from omap2plus_defconfig
> > in the 8250 is the preferred driver?  It seems odd to me that both
> > drivers are enabled.
>
> We have CONFIG_SERIAL_8250_OMAP=y and by default also we have
> CONFIG_SERIAL_8250_OMAP_TTYO_FIXUP=y. With those omap_serial
> won't probe.. So yeah I guess for v5.5 we could drop the
> option for CONFIG_SERIAL_OMAP for both omap2plus_defconfig and
> multi_v7_defconfig.

Do you want me to push a patch for that, or is that something you want to do?

adam
>
> Regards,
>
> Tony