Re: [PATCH] perf/kprobe: maxactive for fd-based kprobe (pmu perf_kprobe)

[Song Liu]

> On Oct 7, 2019, at 4:34 PM, Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> 
> Hi,
> 
> On Mon, 7 Oct 2019 15:31:11 -0700
> Song Liu <songliubraving@xxxxxx> wrote:
> 
>> Enable specifying maxactive for fd based kretprobe. This will be useful
>> for tracing tools like bcc and bpftrace. [1] discussed the need of this
>> in bpftrace. Use highest highest 12 bit (bit 52-63) to allow maximal
>> maxactive of 4095.
>> 
>> [1] https://github.com/iovisor/bpftrace/issues/835
> 
> From the view point of trace_kprobe, this looks good to me.
> 
> Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thanks Masami!

Hi Peter and Steven, 

Could you please share your comments on this?

Thanks,
Song