Re: [PATCH] staging: wfx: fix potential vulnerability to spectre

From: Jerome Pouiller
Date: Fri Oct 11 2019 - 08:35:41 EST


On Friday 11 October 2019 14:10:35 CEST Greg Kroah-Hartman wrote:
> On Fri, Oct 11, 2019 at 10:15:54AM +0000, Jerome Pouiller wrote:
> > From: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>
> >
> > array_index_nospec() should be applied after a bound check.
> >
> > Fixes: 9bca45f3d6924f19f29c0d019e961af3f41bdc9e ("staging: wfx: allow to send 802.11 frames")
>
> No need for the full sha1, this should be:
> Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames")

I copy-pasted information from kbuild robot notification.

I suggest that commit-id in robot notification is also cut down to 12
characters. Or even better, to use this snippet:

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames")

(I added lkp@xxxxxxxxxxxx in CC but, I am not sure it is the correct
ML. I am sorry if it is not the case)

--
Jérôme Pouiller