Re: [PATCH] x86/asm: Make more symbols local

[Borislav Petkov]

On Fri, Oct 11, 2019 at 11:22:13AM +0200, Jiri Slaby wrote:
> During the assembly cleanup patchset reveiew, I found more symbols which

"review"

> are used only locally. So make them really local by prepending ".L" to
> them. Namely:
> * wakeup_idt is used only in realmode/rm/wakeup_asm.S.
> * in_pm32 is used only in boot/pmjump.S.
> * retint_user is used only in entry/entry_64.S, perhaps since commit
>   2ec67971facc ("x86/entry/64/compat: Remove most of the fast system
>   call machinery"), where entry_64_compat's caller was removed.
> 
> Drop GLOBAL from all of them too. I do not see more candidates in the
> series.
> 
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Cc: x86@xxxxxxxxxx
> ---
>  arch/x86/boot/pmjump.S            | 6 +++---
>  arch/x86/entry/entry_64.S         | 4 ++--
>  arch/x86/realmode/rm/wakeup_asm.S | 6 +++---
>  3 files changed, 8 insertions(+), 8 deletions(-)

other than that:

Acked-by: Borislav Petkov <bp@xxxxxxx>

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette