Re: [v3] thunderbolt: Fix to check the return value of kmemdup

From: Markus Elfring
Date: Fri Oct 11 2019 - 09:00:38 EST


> uuid in add_switch is allocted via kmemdup which can fail.

I have tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function âicm_handle_eventâ contains still an unchecked call
of the function âkmemdupâ.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/thunderbolt/icm.c?id=3cdb9446a117d5d63af823bde6fe6babc312e77b#n1627
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/thunderbolt/icm.c#L1627

How do you think about to improve it?

Regards,
Markus