Re: [PATCH] tracefs: Do not allocate and free proxy_ops for lockdown

From: Linus Torvalds
Date: Fri Oct 11 2019 - 17:01:11 EST


On Fri, Oct 11, 2019 at 1:55 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> I guess I can keep it this way. Thoughts?

That looks fine to me. I'm still not sure you actually need to do all
this, but it doesn't look _wrong_.

That said, I still do think that if things are locked down from the
very get-go, tracefs_create_file() shouldn't even create the files.

That's mostly an independent thing from the "what about if they exists
and things got locked down afterwards", though.

I do wonder about the whole "well, if you started tracing before
locking things down, don't you want to see the end results"?

Linus