Re: [PATCH v4 6/8] dt-bindings: iio: adc: max1027: Mark interrupts as optional
From: Jonathan Cameron
Date: Sat Oct 12 2019 - 07:34:50 EST
On Fri, 11 Oct 2019 16:43:45 +0200
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> The chips have a 'start conversion' and a 'end of conversion' pair of
> pins. They can be used but this is absolutely not mandatory as regular
> polling is supported by the chip depending on its internal clocking
> setup.
>
> There is no physical reason to force the use of interrupts so turn
> them optional.
>
> Also, once the interrupt turned optional, these devices fit perfectly
> the "trivial devices" described in the generic (yaml) bindings file, so
> instead of converting this text file to json schema, we can just add
> the relevant compatibles in:
> Documentation/devicetree/bindings/trivial-devices.yaml.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
I guess this keeps things consistent event if we are about to delete it ;)
Applied.
> ---
> Documentation/devicetree/bindings/iio/adc/max1027-adc.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt b/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
> index e680c61dfb84..7b23d68f655c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
> @@ -3,6 +3,8 @@
> Required properties:
> - compatible: Should be "maxim,max1027" or "maxim,max1029" or "maxim,max1031"
> - reg: SPI chip select number for the device
> +
> +Optional properties:
> - interrupts: IRQ line for the ADC
> see: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
>