Re: [PATCH v12 08/16] dt: bindings: lp55xx: Update binding for Multicolor Framework

[Jacek Anaszewski]

Dan,

On 10/12/19 2:54 AM, Dan Murphy wrote:
> Jacek
> 
> On 10/11/19 3:15 PM, Jacek Anaszewski wrote:
>> Dan,
>>
>> On 10/11/19 3:06 PM, Dan Murphy wrote:
>>> Update the DT binding to include the properties to use the
>>> multicolor framework for the devices that use the LP55xx
>>> framework.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
>>> CC: Tony Lindgren <tony@xxxxxxxxxxx>
>>> CC: "BenoÃt Cousson" <bcousson@xxxxxxxxxxxx>
>>> CC: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>> CC: Shawn Guo <shawnguo@xxxxxxxxxx>
>>> CC: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
>>> CC: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
>>> CC: Fabio Estevam <festevam@xxxxxxxxx>
>>> CC: NXP Linux Team <linux-imx@xxxxxxx>
>>> ---
>>>  .../devicetree/bindings/leds/leds-lp55xx.txt | 149 +++++++++++++++---
>>> Â 1 file changed, 124 insertions(+), 25 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
>>> b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
>>> index bfe2805c5534..736a2e1538be 100644
>>> --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
>>> +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
>>> @@ -1,6 +1,8 @@
>>> Â Binding for TI/National Semiconductor LP55xx LED Drivers
>>> Â Â Required properties:
>>> +- #address-cells: 1
>>> +- #size-cells: 0
>>> Â - compatible: one of
>>> ÂÂÂÂÂ national,lp5521
>>> ÂÂÂÂÂ national,lp5523
>>> @@ -14,6 +16,18 @@ Required properties:
>>> Â Each child has own specific current settings
>>> Â - led-cur: Current setting at each LED channel (mA x10, 0 if LED is
>>> not connected)
>>> Â - max-cur: Maximun current at each LED channel.
>>> +- reg: Output channel for the LED. This is zero based channel
>>> identifier and
>>> +ÂÂÂ the data sheet is a one based channel identifier.
>>> +ÂÂÂ reg value to output to LED output number
>>> +ÂÂÂ D1 = reg value is 0
>>> +ÂÂÂ D2 = reg value is 1
>>> +ÂÂÂ D3 = reg value is 2
>>> +ÂÂÂ D4 = reg value is 3
>>> +ÂÂÂ D5 = reg value is 4
>>> +ÂÂÂ D6 = reg value is 5
>>> +ÂÂÂ D7 = reg value is 6
>>> +ÂÂÂ D8 = reg value is 7
>>> +ÂÂÂ D9 = reg value is 8
>>> Â Â Optional properties:
>>> Â - enable-gpio: GPIO attached to the chip's enable pin
>>> @@ -35,23 +49,28 @@ example 1) LP5521
>>> Â on channel 0.
>>> Â Â lp5521@32 {
>> While at it let's fix node prefix to led-controller.
>> It will not break anyone and yet it will adapt the node naming
>> to what is now recommended.
> 
> I would love to do that but honestly I prefer to fix that in a different
> patch series and not add more changes to this patch review.

ack

>>> +ÂÂÂ #address-cells = <1>;
>>> +ÂÂÂ #size-cells = <0>;
>>> ÂÂÂÂÂ compatible = "national,lp5521";
>>> ÂÂÂÂÂ reg = <0x32>;
>>> ÂÂÂÂÂ label = "lp5521_pri";
>>> ÂÂÂÂÂ clock-mode = /bits/ 8 <2>;
>>> Â -ÂÂÂ chan0 {
>>> +ÂÂÂ chan@0 {
>> Similarly in case of every child node:
>>

>>> +Multicolor LED example:
>>> +lp5523: lp5523@32 {
>> Do you really need "lp5523:" node label ?
>>
>> Besides:
>>
>> s/lp5523@32/led-controller@32/
> 
> This change I will make since I added this.

Good, it was the first thing that struck me - if we're
adding new bindings they should conform to the current
standards.

-- 
Best regards,
Jacek Anaszewski