Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warning of Logical continuations should be on the previous line

From: Jules Irenge
Date: Sat Oct 12 2019 - 11:01:39 EST




On Fri, 11 Oct 2019, Julia Lawall wrote:



On Fri, 11 Oct 2019, Jules Irenge wrote:

Fix warning of logical continuations should be on the previous line.
Issue detected by checkpatch tool.

There seem to be several changes mixed together in this patch.

Don't have a subject line that is identical to a line in the log message.
The subject line should be short.

Keeping the arguments of && on the same line, but breaking the line after
a == doesn't seem to be a good idea. It would be better to have the left
argument of == on one line and the right argument on another, if that is
needed.

julia


Apology,
Yesterday was my bday, I was reckless.
I am resending now. Please do not hesitate to give me a feedback if possible.
Thanks
Jules