[PATCH] net: core: skbuff: skb_checksum_setup() drop err
From: Vito Caputo
Date: Sat Oct 12 2019 - 20:31:01 EST
Return directly from all switch cases, no point in storing in err.
Signed-off-by: Vito Caputo <vcaputo@xxxxxxxxxxx>
---
net/core/skbuff.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index f5f904f46893..c59b68a413b5 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -4888,23 +4888,14 @@ static int skb_checksum_setup_ipv6(struct sk_buff *skb, bool recalculate)
*/
int skb_checksum_setup(struct sk_buff *skb, bool recalculate)
{
- int err;
-
switch (skb->protocol) {
case htons(ETH_P_IP):
- err = skb_checksum_setup_ipv4(skb, recalculate);
- break;
-
+ return skb_checksum_setup_ipv4(skb, recalculate);
case htons(ETH_P_IPV6):
- err = skb_checksum_setup_ipv6(skb, recalculate);
- break;
-
+ return skb_checksum_setup_ipv6(skb, recalculate);
default:
- err = -EPROTO;
- break;
+ return -EPROTO;
}
-
- return err;
}
EXPORT_SYMBOL(skb_checksum_setup);
--
2.11.0