Re: [Outreachy kernel] [PATCH 1/2] staging: vc04_services: fix lines ending with open parenthesis
From: Jules Irenge
Date: Sun Oct 13 2019 - 15:02:24 EST
On Sun, 13 Oct 2019, Julia Lawall wrote:
>
>
> On Sun, 13 Oct 2019, Jules Irenge wrote:
>
> > Fix lines ending with open parenthesis. Issue detected by checkpatch tool.
> > In the process, change driver functions name in the multiple files from:
> > vchiq_mmal_port_parameter_set to vmp_prmtr_set
> > vchiq_mmal_component_disable to vm_cmpnt_disable
> > vchiq_mmal_port_connect_tunnel to vmp_cnnct_tunnel
> > vchiq_mmal_component_enable to vm_cmpnt_enable
>
> You should say why you change the names.
>
> As far as I can see, there is no change to the actual function
> definitions, so the code can't compile. Perhaps that comes later in the
> series, but the elements of the series have to be ordered such that
> compilation is possible after each patch.
>
> julia
>
Thanks for the feedback, I am updating it and will be compiling
each point.
Jules