Re: [PATCH] netdevsim: Fix error handling in nsim_fib_init and nsim_fib_exit

[David Miller]

From: YueHaibing <yuehaibing@xxxxxxxxxx>
Date: Fri, 11 Oct 2019 17:46:53 +0800

> In nsim_fib_init(), if register_fib_notifier failed, nsim_fib_net_ops
> should be unregistered before return.
> 
> In nsim_fib_exit(), unregister_fib_notifier should be called before
> nsim_fib_net_ops be unregistered, otherwise may cause use-after-free:
 ...
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Fixes: 59c84b9fcf42 ("netdevsim: Restore per-network namespace accounting for fib entries")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Applied and queued up for -stable.