Re: clk: samsung: Checking a kmemdup() call in _samsung_clk_register_pll()
From: Markus Elfring
Date: Mon Oct 14 2019 - 04:05:28 EST
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/samsung/clk-pll.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n1275
>> https://protect2.fireeye.com/url?k=7e77b0ebee9a0c3e.7e763ba4-43f341fdfe1d32b1&u=https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/clk/samsung/clk-pll.c#L1275
â
> drivers/clk/samsung/clk-pll.c considers the case of 'pll->rate_table is NULL'
> So, maybe just show the warning message if failed to allocate memory
> of 'pll->rate_table'.
How do you think about to recheck information sources around
the Linux allocation failure report?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=da94001239cceb93c132a31928d6ddc4214862d5#n878
> Bu, IMHO, the error handling is necessary in order to support
> what 'pll_clk->rate_table' isn't NULL.
Can an other error handling strategy make sense at this place?
Regards,
Markus