Re: [PATCH] ath10k: Correct error check of dma_map_single()

[Kalle Valo]

Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> writes:

> On Fri 11 Oct 04:57 PDT 2019, Kalle Valo wrote:
>
>> Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote:
>> 
>> > The return value of dma_map_single() should be checked for errors using
>> > dma_mapping_error(), rather than testing for NULL. Correct this.
>> > 
>> > Fixes: 1807da49733e ("ath10k: wmi: add management tx by reference
>> > support over wmi")
>> > Cc: stable@xxxxxxxxxxxxxxx
>> > Reported-by: Niklas Cassel <niklas.cassel@xxxxxxxxxx>
>> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>> 
>> Did this fix any real bug? Or is this just something found during code review?
>> 
>
> CONFIG_DMA_API_DEBUG screamed at us for calling dma_unmap_single()
> without ever having called dma_mapping_error() on the return value.

Ok, I'll add something about to the commit log in v2 so that the
background is also documented.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches